Issue Queue

Resonsive images in Boostrap Theme and ckeditor content

Wed, 04/10/2019 - 03:26

Hello,

I would like to be able to make images that are uploaded to the body in ck-editor responsive with the img-responsive. This would make my users life so much easier as currently we have to go into source and add the class to figure and width 100% to the image.

This is what the result looks like in source :

<img alt="This is the image that I browsed" class="img-responsive" data-align="center" data-caption="This is an image of a thing that is interesting" data-entity-type="file" data-entity-uuid="aef36450-8277-4321-8801-05c36a9156d6" src="/sites/default/files/inline-images/948x457.png" style="width : 100%" />

This is turn renders the folowing html in the page :

<figure role="group" class="img-responsive align-center"> <img alt="This is the image that I browsed" data-entity-type="file" data-entity-uuid="aef36450-8277-4321-8801-05c36a9156d6" src="/sites/default/files/inline-images/948x457.png" style="width : 100%"> <figcaption>This is an image of a thing that is interesting</figcaption> </figure>

I am wondering if there is a configuration for CKeditor or image upload that could allow the user to juste say "I want this image to be responsive"?

PS : I hope that I have posted this in the right place. I was hesitating between here and the CKeditor issues... I'm curretnly learning Bootsrap theme in Drupal 8 after a 3 year hiatus from Drupal 7. Thanks for the great work on this Bootstrap Drupal Theme it's really great to use!

Categories: Issue Queue Activity

Proplem after updating Bootstrap 7.x-3.23

Fri, 04/05/2019 - 03:43

Hi,

I am facing an issue on my sites after updating Bootstrap theme to the 7.x-3.23.

It looks like all the theme is going crazy.

I have PHP 7.2 on server and a child theme. CDN is provided by jsDelivr with 3.0.0 version.

I don't understand where is coming the problem! From my Sub Theme or Bootstrap itself?

Does anyone experienced that?
Any suggestion would be appreciated!

Thank you

Categories: Issue Queue Activity

nav role=&quot;navigation&quot; seems redundant

Thu, 04/04/2019 - 19:56

W3C validator throws a warning at this redundant code. Is role="navigation" required for some reason? I see the twig template specifically DOES NOT print the Drupal-provided role and role="navigation" is hard-coded into the template. It seems this has been here from the beginning of 8.x-3.x

Could we remove it without affecting anything?

Categories: Issue Queue Activity

Menu items encounter NULL attributes

Wed, 04/03/2019 - 12:18
Problem/Motivation

Drupal core: 8.7.0-beta1
Bootstrap: 3.17.0
fontawesome_menu_icons: 1.5.0

When switching to non-bootstrap themes, such as Bartick, sub-theme of AdaptiveTheme, the errors as blew are gone. So I am wondering this is a bug of the Bootstrap theme.

Warning: assert(): $attributes, if set, must be an array or object of type \Drupal\Core\Template\Attribute failed in Drupal\Core\Template\TwigExtension->getLink() (line 285 of /var/www/html/web/core/lib/Drupal/Core/Template/TwigExtension.php) #0 /var/www/html/web/core/includes/bootstrap.inc(587): _drupal_error_handler_real(2, 'assert(): $attr...', '/var/www/html/w...', 285, Array) #1 [internal function]: _drupal_error_handler(2, 'assert(): $attr...', '/var/www/html/w...', 285, Array) #2 /var/www/html/web/core/lib/Drupal/Core/Template/TwigExtension.php(285): assert(false, '$attributes, if...') #3 /var/www/html/web/sites/default/files/php/twig/5ca0db9f2cd99_menu.html.twig_VUQ6iE4VQToBSVI9Bfo_dn2WZ/hy8u3Eo9C2k_NpuyYBd6kh3wsa0qpyBsqI3EjezVbAw.php(145): Drupal\Core\Template\TwigExtension->getLink('Expense Request...', Object(Drupal\Core\Url), NULL) #4 /var/www/html/vendor/twig/twig/src/Template.php(673): __TwigTemplate_1cdc7ede551542f24a1d35b3ce5dabeb1d4fde609ae1e6babc47569282368a5d->getmenu_links(Array, Object(Drupal\Core\Template\Attribute), 1, Array, Array) #5
...

Proposed resolution $ git diff diff --git a/src/Plugin/Preprocess/Menu.php b/src/Plugin/Preprocess/Menu.php index 9af5dc6..019e0c8 100644 --- a/src/Plugin/Preprocess/Menu.php +++ b/src/Plugin/Preprocess/Menu.php @@ -35,8 +35,8 @@ class Menu extends PreprocessBase implements PreprocessInterface { // Unfortunately, in newer core/Twig versions, only certain classes are // allowed to be invoked due to stricter sandboxing policies. To get // around this, just rewrap attributes in core's native Attribute class. - $item['attributes'] = new Attribute($wrapperAttributes->getArrayCopy()); - $item['link_attributes'] = new Attribute($linkAttributes->getArrayCopy()); + $item['attributes'] = new Attribute($wrapperAttributes->getArrayCopy()) ?: []; + $item['link_attributes'] = new Attribute($linkAttributes->getArrayCopy()) ?: []; } }
Categories: Issue Queue Activity

Working offline

Sun, 03/31/2019 - 01:36

Hello,

I would like to work offline to not be distracted amongst other things but if I choose "None" under the advanced tab of Bootstrap settings in "admin/appearance/settings/paperlight" (my subtheme), my subtheme doesn't load the Boostrap CSS files anymore as it does when my Internet connection is active. How can I do this?

My version of Bootstrap is Bootstrap 7.x-3.23

Thanks a bunch!

Categories: Issue Queue Activity

Context sensitive string

Sun, 03/24/2019 - 06:52

Bad:

$description .= t('See also:'); $description .= ' ' . implode(', ', $links);

Good:

$description .= t('See also: @links', ['@links' => implode(', ', $links)]);
Categories: Issue Queue Activity

Bootstrap Carousel not working properly on latest update?

Fri, 03/08/2019 - 06:51

Hello,

is there anyone who managed to get latest Drupal 8 Bootstrap theme to properly show Bootstrap Carousel?

I did everything the same I did with Bootstrap 3 for Drupal 7:
1. Added content type Slider
2. Added Slider1,2 and 3 with that content type
3. Created a block with Views, selected to show content of type Slider
4. In View selected to render Title from Title and Image form Image field.

However, the sliding does not work. It only shows one image under another, like this:

********
* image *
********
********
* image *
********
********
* image *
********

Instead of usual, one image and then sliding through it.
Any ideas on this one?

Thanks

Categories: Issue Queue Activity

somehow support adding/editing aria-labelledby to block sections

Wed, 03/06/2019 - 12:45

When blocks or regions are set in the DOM, they are placed in tags. For accessibility purposes, these landmark sections should have aria-labelledby attributes that point to the ID of their internal header, if possible. It would be nice if this module somehow allowed that. I honestly don't have a clue how that would be implemented, but would be happy to have a discussion about it.

Categories: Issue Queue Activity

hook_preprocess_fieldset seems not to be evaluated for fieldsets that use bootstrap-panel.html.twig

Wed, 02/27/2019 - 03:39

I would like add the class 'panel-primary' to some (not all) panels. I tried to use hook_preprocess_fieldset to add this class but this hook seems not to work with the bootstrap theme. Is there a better or correct way of doing this?

Categories: Issue Queue Activity

Bootstrap requires jQuery 1.7 or greater

Wed, 02/20/2019 - 21:06

When I visit the status report page (admin/reports/status) I see a warning in pink saying:

Bootstrap version
Bootstrap requires jQuery 1.7 or greater. Configure jQuery Update.

And it shows me that I have jQuery 1.10.2
When I visit my jQuery Update page it shows that I have set it to:
Default version: 1.10
Alternate version: 1.10
jQuery compression level: Production (minified)
jQuery and jQuery UI CDN: jQuery

Why is this warning showing if my jQuery version is greater than 1.7 as Bootstrap is requesting?
And is this error message affecting my theme at all actually?

Categories: Issue Queue Activity

Glyphicons rendered as blank square

Wed, 02/20/2019 - 00:20

I've created a subtheme according to https://drupal-bootstrap.org/api/bootstrap/7.x-3.x using sass starterkit.

In a custom module I've defined a callback to produce a carousel and found that class "glyphicon glyphicon-chevron-right" is rendered as a blank square (also left one of course).
Everything is fine using bootstrap base theme - or bootstrap lite which uses cdn - but not with mine.

What's wrong with subtheming?
Regards

Categories: Issue Queue Activity

Bootswatch needs static mapping for broken/missing versions

Thu, 02/14/2019 - 13:35
Problem/Motivation

While the Bootswatch project attempts to maintain version parity with Bootstrap, it doesn't always happen.

https://github.com/thomaspark/bootswatch/issues/892#ref-issue-410070082

This causes issues in the theme selection UI which expects a 1:1 version match between Bootstrap and Bootswatch.

Proposed resolution

Create ProviderBase::mapVersion($package, $version) to help accomodate inconsistences within published packages.

Remaining tasks
  • Create patch
User interface changes

None

API changes

None

Data model changes

None

Categories: Issue Queue Activity

.has-error on required field forms

Thu, 02/14/2019 - 03:46

On content type comment form, when a user wants to edit their comments, all the required fields are red (.error .has-error) when there is clearly already an answer in the field.
I have it also on Register form, when I didn't even click or anything, just loaded the page.
How do I fix that?

TIA

Categories: Issue Queue Activity

Missed Wrapper after opening modal window

Thu, 02/14/2019 - 02:57

I have problem with opening modal window from another modal window.

I have used such code for open window

<a href="/link" class="use-ajax btn-info btn" data-dialog-type="modal" data-drupal-link-system-path="link">{{ 'Name'|t }}</a>

Problem have appeared after update to 3.17
3.16 works fine

Notice:
everything works well when you try to open popup from page. Error appears only after opening another popup from first popup.

Categories: Issue Queue Activity

Default to Bootstrap 3.4.1

Wed, 02/13/2019 - 11:12
Categories: Issue Queue Activity

Reduce time it takes to populate CDN assets from cold cache request

Thu, 02/07/2019 - 11:50
Problem/Motivation

Due to jsDelivr changing how their API works (essentially a v2 bump), multiple requests must now be made to complete what used to be done in just one. This has caused cache rebuild times to become increasingly long due to how the code is currently constructed.

Proposed resolution
  1. Restructure the API requests so they only pull and process the version actually selected.
  2. Add an additional "cache barrier" in the theme settings so it stores the currently selected CDN assets so it can survive a cache clear and not require requesting from the API.
Categories: Issue Queue Activity

Bootstrap 7.x-3.23 not suport PHP 5.3 add minium PHP version

Thu, 01/31/2019 - 06:56

Bootstrap 7.x-3.23 not support PHP 5.3 due to short array syntax but Drupal 7 is still compatible.

We should add a requirement in module info.

Categories: Issue Queue Activity

Can&#039;t select any layout in manage display configuration (Subtheme)

Tue, 01/29/2019 - 03:43

Since I updated the drupal core to 8.6.3 I can't select a layout for the content type in manage display (/admin/structure/types/manage/CONTENTTYPE_NAME/display). This Bug appears even with the drupal core 8.6.7.

I use a drupal substheme with sass on my website.

Have someone an idea what the issue could be?

Categories: Issue Queue Activity

How to use breakpoints with Content module

Sun, 01/27/2019 - 14:53

How can I make the breakpoints defined in bootstrap theme available to context module's conditions list.

Categories: Issue Queue Activity